Re: [PATCH] usb: dwc3: debugfs: fixes debugfs regdump returning all zeros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

CC: Ido Shayevitz

On Tue, Aug 21, 2012 at 5:48 PM, Vikas Sajjan <vikas.sajjan@xxxxxxxxxxx> wrote:
> Even though the mem region is requested from the Globals address
> space (DWC3_GLOBALS_REGS_START), the offsets are given from the
> starting of the xHCI address space.
>
> By subtracting DWC3_GLOBALS_REGS_START from the offset ( as done in
> dwc3_readl() and dwc3_writel() ) resolves the issue.
>
> Signed-off-by: Vikas C Sajjan <vikas.sajjan@xxxxxxxxxxx>
> ---
>  drivers/usb/dwc3/debugfs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> index d4a30f1..51c55bb 100644
> --- a/drivers/usb/dwc3/debugfs.c
> +++ b/drivers/usb/dwc3/debugfs.c
> @@ -56,7 +56,7 @@
>  #define dump_register(nm)                              \
>  {                                                      \
>         .name   = __stringify(nm),                      \
> -       .offset = DWC3_ ##nm,                           \
> +       .offset = DWC3_ ##nm - DWC3_GLOBALS_REGS_START  \
This seems to be a valid change, which goes in-line with 51249dc for debugfs.
Balbi, Ido any comments here?
>  }
>
>  static const struct debugfs_reg32 dwc3_regs[] = {
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Best Regards
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux