Re: [PATCH] USB: ohci-s3c2410: use devm_ functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, October 05, 2012 11:35 PM Alan Stern wrote
> 
> On Fri, 5 Oct 2012, Jingoo Han wrote:
> 
> > The devm_ functions allocate memory that is released when a driver
> > detaches. This makes the code smaller and a bit simpler.
> >
> > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> 
> > -	hcd->regs = ioremap(hcd->rsrc_start, hcd->rsrc_len);
> > +	hcd->regs = devm_ioremap(&dev->dev, hcd->rsrc_start, hcd->rsrc_len);
> 
> You could shrink the code even farther by using
> devm_request_and_ioremap().


OK, I will used devm_request_and_ioremap() and send v2 patch.
Thank you.

Best regards,
Jingoo Han


> 
> Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux