Re: [PATCH 0/2] usb: vt8500: Fixups for 3.7

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2012-10-07 at 11:44 -0400, Alan Stern wrote:
> On Sun, 7 Oct 2012, Tony Prisk wrote:
> 
> > When probed from devicetree, dma_mask is not set but is required by
> > the usb subsystem. These patches add a default dma_mask when not
> > specified.
> > 
> > Tony Prisk (2):
> >   usb: Missing dma_mask in uhci-platform.c when probed from device-tree
> >   usb: Missing dma_mask in ehci-vt8500.c when probed from device-tree
> 
> How about instead of changing ehci-vt8500.c, remove it completely and 
> use ehci-platform instead?  The changes required should be minimal, 
> especially after ehci_update_device() get moved into ehci-lpm.c and 
> added to the hc_driver structure for ehci-platform.c.
> 
> Alan Stern

The main reason I used ehci-vt8500.c is that it works at the moment, and
this was supposed to be a bug-fix.

I agree that we should be using -platform, but it currently doesn't have
a DT binding, so it's unlikely that I could get a binding formalized and
the changes made to fix the current issue for 3.7

Regards

Tony P

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux