Hello Sebastian Andrzej Siewior,
The patch 3b9c1c5ba7a95: "usb: gadget: dummy_hcd: add support for
USB_DT_BOS on rh" from Oct 19, 2012, leads to the following warning:
drivers/usb/gadget/dummy_hcd.c:2038 dummy_hub_control()
error: memcpy() 'buf' too small (15 vs 16)
2031 case DeviceRequest | USB_REQ_GET_DESCRIPTOR:
2032 if (hcd->speed != HCD_USB3)
2033 goto error;
2034
2035 if ((wValue >> 8) != USB_DT_BOS)
2036 goto error;
2037
2038 memcpy(buf, &usb3_bos_desc, sizeof(usb3_bos_desc));
^^^^^^^^^^^^^^^^^^^^^^
2039 retval = sizeof(usb3_bos_desc);
2040 break;
buf is declared in rh_call_control() as:
u8 tbuf[USB_DT_BOS_SIZE + USB_DT_USB_SS_CAP_SIZE]
__attribute__((aligned(4)));
The new code might work because of the alignment, but it's not
beautiful.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
