Re: [PATCH] usb: gadget: Add Interface Association Descriptor to ECM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 7, 2012 at 8:51 PM, Sebastian Andrzej Siewior
<sebastian@xxxxxxxxxxxxx> wrote:
> On Wed, Jan 25, 2012 at 11:02:03AM +0100, Linus Walleij wrote:

>>  static struct usb_descriptor_header *ecm_fs_function[] = {
>>       /* CDC ECM control descriptors */
>> +     (struct usb_descriptor_header *) &ecm_iad_descriptor,
>>       (struct usb_descriptor_header *) &ecm_control_intf,
>>       (struct usb_descriptor_header *) &ecm_header_desc,
>>       (struct usb_descriptor_header *) &ecm_union_desc,
>> @@ -247,6 +262,7 @@ static struct usb_endpoint_descriptor hs_ecm_out_desc = {
>>
>>  static struct usb_descriptor_header *ecm_hs_function[] = {
>>       /* CDC ECM control descriptors */
>> +     (struct usb_descriptor_header *) &ecm_iad_descriptor,
>>       (struct usb_descriptor_header *) &ecm_control_intf,
>>       (struct usb_descriptor_header *) &ecm_header_desc,
>>       (struct usb_descriptor_header *) &ecm_union_desc,
>
> Why did you add this IAD thingy to FS and HS and not SS descriptors? I don't
> see a reason so I would guess you just forgot :)

Argh, Praveena, save me here ... I was being patch secretary
this time, but to my untrained USB-eyes it looks like you're right,
interested in patching it?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux