On Thu, Sep 06 2012, Sebastian Andrzej Siewior wrote:
> It was moved to be an argument in 07a18bd716ed5 ("usb gadget: don't
> save bind callback in struct usb_composite_driver"). The reason was to
> avoid the section missmatch. The warning was shown because ->bind is
> marked as __init becuase it is a one time init. The warning can be also
> suppresed by whitelisting the variable i.e. rename it to lets say _probe.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Would it make sense to merge patches 2, 4, 5 and 6 into a single one?
They all deal with the same thing (ie. they bring back ->bind callback)
and it seems to me like all those changes belong in a single patch as
otherwise they produce some intermediate states, which don't have clean
purpose.
For instance this patch fiddles with composite_bind_probe() so that it
allows both the bind argument and driver->bind callback, but than patch
5 fiddles with this even more removing bind argument.
Others may disagree, but I feel that those changes would be simpler to
understand if put as a single patch. Also, even though I wrote three
paragraphs on that issue, I don't have strong feelings, and:
Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--Attachment:
pgpKmGtLsh3bQ.pgp
Description: PGP signature
