Re: [PATCH] usb: dwc3: correct default value of maxburst

[Felipe Balbi <balbi@xxxxxx>]

Hi,

On Wed, Aug 29, 2012 at 10:49:58AM +0900, Chanho Park wrote:
> This patch changes default value of maxburst to 1. When a connection is
> established to highspeed, the maxburst is set to 0. So, we need to check and
> change default value of the maxburst before setting up burst size of ep.
> 
> Signed-off-by: Chanho Park <chanho61.park@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
>  drivers/usb/dwc3/gadget.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 58fdfad..025a1bc 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -437,6 +437,9 @@ static int dwc3_gadget_set_ep_config(struct dwc3 *dwc, struct dwc3_ep *dep,
>  
>  	memset(&params, 0x00, sizeof(params));
>  
> +	if (!dep->endpoint.maxburst)
> +		dep->endpoint.maxburst = 1;

a better patch would be to only check maxburst if endpoint is
ss-capable. You can just check if comp_desc is a valid pointer (aka not
NULL).

-- 
balbi

Attachment: signature.asc
Description: Digital signature