On Mon, 30 Jul 2012, Oliver Neukum wrote: > On Monday 30 July 2012 15:58:25 Lan Tianyu wrote: > > On 2012年07月30日 15:24, Oliver Neukum wrote: > > > > this is on second thought quite problematic. If user space has > > > disabled the persist feature it must stay disabled, even if > > > the quirk setting is removed. > > Yeah. You are right. So how about remain the persist_enabled 0 or > > do nothing with persist_enabled when quirk settting is removed. > > Hi, > > this leads to behavior that is not easy to predict or understand. > It would be cleaner to leave the flag alone and check for the quirk > in addition for the flag when the check is done. I disagree. Leaving the flag set but then not implementing the persist behavior would be confusing also. Maybe even worse. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html