On Mon, 30 Jul 2012, Oliver Neukum wrote: > On Monday 30 July 2012 11:34:10 Lan Tianyu wrote: > > The hub is always supposed to support reset and its persist is enabled. > > By default, not necessarily always. User space may disable it. No -- necessarily always. Userspace cannot disable it. The persist attribute doesn't even exist for hub devices. > > So hub doesn't need attribute avoid_reset_quirk. The patch is to take > > attribute avoid_reset_quirk out of usb device's attribute group and > > add or remove it in the usb_create/remove_sysfs_dev_files() if the device > > is not a usb hub. > > Why? What is gained doing so? Without further explanation about the need > or benefit of doing so, why do you want to make hubs different from > other devices? They already are different. The patch does not make the difference any bigger. A hub that needs a firmware update after a reset probably is not worth supporting. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
