Hi
> On Thu, Jul 26, 2012 at 12:46:43PM +0000, Gupta, Ajay Kumar wrote:
> > Hi,
> > > > > > On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote:
> > > > > > > @@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct
> > > > > > > musb
> > > > *musb)
> > > > > > > struct dentry *root;
> > > > > > > struct dentry *file;
> > > > > > > int ret;
> > > > > > > + char name[10];
> > > > > > >
> > > > > > > - root = debugfs_create_dir("musb", NULL);
> > > > > > > + sprintf(name, "musb%d", musb->id);
> > > > > > > + root = debugfs_create_dir(name, NULL);
> > > > > >
> > > > > > I told you to use dev_name(musb) for a reason. See what
> > > > > > happens when you use dev_name(musb);
> > > > > >
> > > > > > Do you not think about the other users of this driver ? Do you
> > > > > > not know what's the ID on platform_devices which "don't have an
> ID" ??
> > > > >
> > > > > We are now using musb_ida for all glue layers so '-1' issue will
> > > > > not
> > > come.
> > > >
> > > > true.
> > > >
> > > > > Still if we can manage without 'id' then better to do that way.
> > > >
> > > > just make sure to notice that directory name will "musb.0".
> >
> > It creates musb-hdrc.0 and musb-hdrc.1 as glue layers use "musb-hdrc"
> > name in platform_device_alloc() call.
>
> yes, indeed. That shouldn't be a problem though... what do you think ?
I agree with you as that should be fine.
Ajay
>
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
