Hi, On Wed, Jul 25, 2012 at 05:37:22PM +0530, Ajay Kumar Gupta wrote: > diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x.c > index 01203eb..eb6220f 100644 > --- a/drivers/usb/musb/am35x.c > +++ b/drivers/usb/musb/am35x.c > @@ -364,7 +364,7 @@ static int am35x_musb_init(struct musb *musb) > if (!rev) > return -ENODEV; > > - usb_nop_xceiv_register(); > + usb_nop_xceiv_register(musb->id); > musb->xceiv = usb_get_phy(USB_PHY_TYPE_USB2); > if (IS_ERR_OR_NULL(musb->xceiv)) > return -ENODEV; > @@ -408,7 +408,7 @@ static int am35x_musb_exit(struct musb *musb) > data->set_phy_power(0); > > usb_put_phy(musb->xceiv); > - usb_nop_xceiv_unregister(); > + usb_nop_xceiv_unregister(musb->xceiv); Dude, this is so wrong... You don't know if there are other users of the nop xceiv in the system. If there are other users which already have claimed id 0, you will try to create duplicated directories under sysfs. MUSB's ID has nothing to do with NOP's ID. -- balbi
Attachment:
signature.asc
Description: Digital signature
