Re: [PATCH] USB: musb: NAK timeout scheme on bulk TX endpoint

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 25, 2012 at 10:38:59AM +0000, Gupta, Ajay Kumar wrote:
> Hi,
> > > On Thu, Jul 19, 2012 at 01:41:59PM +0530, Ajay Kumar Gupta wrote:
> > > > Fixes endpoint starvation issue when more than one bulk QH is
> > > > multiplexed on the reserved bulk TX endpoint.
> > > >
> > > > This patch sets the NAK timeout interval for such QHs, and when
> > > > a timeout triggers the next QH will be scheduled.
> > > >
> > > > This scheme doesn't work for devices which are connected to a
> > > > high to full speed tree (transaction translator) as there is
> > > > no NAK timeout interrupt from the musb controller from such
> > > > devices.
> > > >
> > > > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@xxxxxx>
> > >
> > > Are you saying this patch will break full speed devices when we have a
> > > HS hub in between ? If that's the case I cannot take this patch...
> > 
> > This only says that this NAK timeout scheme will not work in such cases
> > and so will continue to work the way it is currently available. Which means
> > IN tokens being sent continuously to a NAKing device.
> 
> and for OUT case, PING token being sent to a NAKing device and we not able
> to use NAK timeout scheme to use the hardware endpoint resource for other
> devices.

Ok, I misunderstood the commit log. Thought you were saying there would
be a regression. Nevermind.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux