[RFC 0/7] LPM fixes and LTM v2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg, Alan, and Andiry,

Here's revision 2 of the Latency Tolerance Messaging (LTM) patchset.

The first four patches are bug fixes for the Link Power Management (LPM)
code.  As I told Alan, I discovered that unconfigured USB 3.0 devices
can't be sent a Set/Clear Feature U1/U2 request.  These four patches
rework the USB core LPM code to only enable and disable LPM when the
device is configured.

The last three patches are a new revision of the LTM patchset.  Changes
since v1:
 - Fix the xHCI driver to actually export the LTM capability
 - Add a sysfs file in the usb device directory called ltm_capable
 - Remove the forward declarations of usb_enable/disable_ltm()
 - Don't check for !hcd
 - Remove confusing comment in usb_disable_ltm()
 - Simplify LTM disable/enable in usb_reset_and_verify_device()

The last change was actually quite easy once I fixed the LPM code to not
enable LPM when the device was unconfigured.  That removed a lot of the
usb_enable_lpm() calls in usb_reset_and_verify_device(), and most of the
calls to usb_enable_ltm() have been removed for the same reason.

Greg, I didn't know whether the LPM fixes could make it into your
usb-linus queue before the merge window, so I marked them for 3.5
stable.

Sarah Sharp


The following changes since commit ff9cce82772a78983b529e044d85884d3ec95fda:

  Merge tag 'xceiv-for-v3.6' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next (2012-07-05 15:35:41 -0700)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git ltm-v3

for you to fetch changes up to e18bbb85c492445fe091035f011f39ef4f6d382f:

  USB: Add a sysfs file to show LTM capabilities. (2012-07-05 18:51:43 -0700)

----------------------------------------------------------------
Sarah Sharp (7):
      xhci: Fix LPM disable/enable during device reset.
      xhci: Disable LPM while the device is unconfigured.
      USB: Fix LPM disable count mismatch on driver unbind.
      USB: Remove unused LPM variable.
      xhci: Export Latency Tolerance Messaging capabilities.
      USB: Enable Latency Tolerance Messaging (LTM).
      USB: Add a sysfs file to show LTM capabilities.

 drivers/usb/core/hub.c      |  100 +++++++++++++++++++++++++++++++++++-------
 drivers/usb/core/message.c  |   11 +++-
 drivers/usb/core/sysfs.c    |   10 ++++
 drivers/usb/core/usb.c      |    1 +
 drivers/usb/host/xhci-hub.c |    6 +++
 include/linux/usb.h         |   12 +++++-
 6 files changed, 119 insertions(+), 21 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux