Re: [PATCH 1/2] usb: musb: kill global and static for multi instance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hi,

On Mon, Jul 02, 2012 at 08:46:33AM +0000, Gupta, Ajay Kumar wrote:
> > > +#ifndef CONFIG_MUSB_PIO_ONLY
> > > +	musb->orig_dma_mask = dev->dma_mask; #endif
> > 
> > this I can't accept, you can just point to the parent device's dma_mask.
> Each glue layer initialize it to "DMA_BIT_MASK(32)" and same is set for
> Parent device in usb-musb.c so I think it should be safe to point to
> Parent device's dma_mask during musb_remove.
> 
> Additionally I have to remove "musb_debugfs_root" from musb_debugfs.c to
> musb structure.

indeed, that should be part of struct musb. Don't know what I had in my
mind when I did that :-p My bad.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux