On Mon, Jun 11, 2012 at 7:35 PM, Ming Lei <tom.leiming@xxxxxxxxx> wrote:
> On Tue, Jun 12, 2012 at 12:22 AM, Grant Grundler <grundler@xxxxxxxxxxxx> wrote:
>> Asix driver triggers this warning in the USB subsystem:
>> asix 1-7:1.0: no reset_resume for driver asix?
>>
>> The (cut/paste) patch below "fixes" the warning...but I didn't find (a
>> few monthes ago)
>> documentation to explain the difference and it feels wrong. Advice?
>
> .reset_resume callback is called after the suspended USB device
> has been reset during resume path.
>
> Without .reset_resume callback implemented, USB core will unbind and
> rebind all interfaces of the USB device during resume, so the network
> interface may become DOWN from UP after one suspend/reset_resume
> circle.
Ming,
Thanks for the explanation. I tested this again on a laptop (CR48)
that keeps the USB powered during suspend/resume and I couldn't
reproduce the output...I'm probably doing something stupid. I did
check that /proc/sys/kernel/printk was "4 5 1 7".
The rest of the ChromeOS laptops I tested power off the USB ports and
a disconnect event happens anyway at resume. So I'm not going to
pursue this any further.
thanks,
grant
>
>>
>> thanks,
>> grant
>>
>> diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c
>> index 42b5151..f192496 100644
>> --- a/drivers/net/usb/asix.c
>> +++ b/drivers/net/usb/asix.c
>> @@ -1645,6 +1645,7 @@ static struct usb_driver asix_driver = {
>> .probe = usbnet_probe,
>> .suspend = usbnet_suspend,
>> .resume = usbnet_resume,
>> + .reset_resume = usbnet_resume,
>
> If the change can make your network interface behave good
> after undergoing reset_resume, it should be good.
>
>> .disconnect = usbnet_disconnect,
>> .supports_autosuspend = 1,
>> };
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
> Thanks,
> --
> Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
