On Mon, 2 Jul 2012, Hans de Goede wrote: > >> +static int proc_get_capabilities(struct dev_state *ps, void __user *arg) > >> +{ > >> + __u32 caps; > >> + > >> + caps = USBDEVFS_CAP_ZERO_PACKET | USBDEVFS_CAP_NO_PACKET_SIZE_LIM; > >> + caps |= USBDEVFS_CAP_BULK_CONTINUATION; > >> + > >> + if (put_user(caps, (__u32 __user *)arg)) > >> + return -EFAULT; > >> + > >> + return caps; > >> +} > > > > This should return 0, not caps. > > Right/ack, so can you fix this while merging, or do you want a resend? I don't do the merging -- Greg KH does. So it's up to him. Be sure to send your patches to him (or at least CC: him) in the final submission. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html