[PATCH] USB/ehci-spear: Fix ehci suspend to avoid recursive spin lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Deepak Sikri <deepak.sikri@xxxxxx>

'ehci_prepare_ports_for_controller_suspend()' function already takes the
spinlock hence call this function without holding spinlock.

Signed-off-by: Deepak Sikri <deepak.sikri@xxxxxx>
Signed-off-by: Shiraz Hashim <shiraz.hashim@xxxxxx>
---
 drivers/usb/host/ehci-spear.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c
index 37ba8c8..fbd5bd7 100644
--- a/drivers/usb/host/ehci-spear.c
+++ b/drivers/usb/host/ehci-spear.c
@@ -109,8 +109,8 @@ static int ehci_spear_drv_suspend(struct device *dev)
 	 * unaccessible. The PM and USB cores make sure that the root hub is
 	 * either suspended or stopped.
 	 */
-	spin_lock_irqsave(&ehci->lock, flags);
 	ehci_prepare_ports_for_controller_suspend(ehci, device_may_wakeup(dev));
+	spin_lock_irqsave(&ehci->lock, flags);
 	ehci_writel(ehci, 0, &ehci->regs->intr_enable);
 	ehci_readl(ehci, &ehci->regs->intr_enable);
 	spin_unlock_irqrestore(&ehci->lock, flags);
-- 
1.7.10

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux