On 06/27/2012 08:20 AM, Richard Zhao wrote: > On Mon, Jun 25, 2012 at 12:33:58PM +0200, Marc Kleine-Budde wrote: >> On 06/25/2012 08:56 AM, Richard Zhao wrote: >>> This patch supports only the host-mode functionality so far. >>> >>> Signed-off-by: Richard Zhao <richard.zhao@xxxxxxxxxxxxx> >>> Signed-off-by: Marek Vasut <marex@xxxxxxx> >>> Cc: Peter Chen <peter.chen@xxxxxxxxxxxxx> >>> Cc: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx> >>> Cc: Felipe Balbi <balbi@xxxxxx> >>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >>> Tested-by: Subodh Nijsure <snijsure@xxxxxxxxxxxx> >>> --- >>> .../devicetree/bindings/usb/ci13xxx-imx.txt | 20 ++ >>> drivers/usb/chipidea/Makefile | 3 + >>> drivers/usb/chipidea/ci13xxx_imx.c | 197 ++++++++++++++++++++ >>> 3 files changed, 220 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/usb/ci13xxx-imx.txt >>> create mode 100644 drivers/usb/chipidea/ci13xxx_imx.c >>> >>> diff --git a/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt b/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt >>> new file mode 100644 >>> index 0000000..8bcd071 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt >>> @@ -0,0 +1,20 @@ >>> +* Freescale i.MX ci13xxx usb controllers >>> + >>> +Required properties: >>> +- compatible: Should be "fsl,imx27-usb" >>> +- reg: Should contain registers location and length >>> +- interrupts: Should contain controller interrupt >>> + >>> +Optional properties: >>> +- fsl,usbphy: phandler of usb phy that connects to the only one port >> >>> +- fsl,hub-reset-gpios: gpio used to reset on-board usb hub >>> +- fsl,vbus-power-gpios: gpio used to set vbus power of the only one port >> >> These two properties are not implemented, are they? >> vbus is handled via a fixed regulator. > I forgot to update the doc. >> >> Further I'm looking into the phy and otg implementation. I think the >> handling of the regulator should go into mxs-phy.c, not into the >> ci13xxx_imx.c > Normally, we don't put it in phy driver. For example, most host driver > don't call phy drivers. Yes, I've noticed that otg support is ... a bit messy in the linux kernel. There are some drivers that implement a otg state machine. However, I have the udc on mx28 somewhat working. It's still a hack since I have to implement an otg driver for this, but the host part doesn't do otg so far...and unplug is not detected correctly. cheers, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachment:
signature.asc
Description: OpenPGP digital signature
