On Mon, Jun 25, 2012 at 01:40:20PM -0700, AbeOwitz wrote:
> Hello Sarah,
>
> Forgive me if this isn't the approved way to submit patches & such, but I'm
> not to sure of what I'm doing. Best to leave it to you experts. ;)
Nah, you don't have to be an expert to submit a patch. You just have to
read Documentation/SubmittingPatches and follow the directions there. :)
> I have an Asus N73JQ, which has the Fresco Logic 0x1b73:1400 chipset for
> xhci/usb3. I tried replacing the PCI ID from 1000 to 1400, in xhci-pci.c,
> but it seems the XHCI_RESET_EP_QUIRK causes problems.
>
> So, I just added this define:
> #define PCI_DEVICE_ID_FRESCO_LOGIC_PDK*2* 0x1400
Astrix in constant variable names aren't very readable. Also, you
obviously don't have a PDK (product development kit), so why not call it
PCI_DEVICE_ID_ASUS_N73JQ_XHCI?
> and this if statement after the first Fresco if block:
>
> if (pdev->vendor == PCI_VENDOR_ID_FRESCO_LOGIC &&
> pdev->device == PCI_DEVICE_ID_FRESCO_LOGIC_PDK*2*) {
> xhci->quirks |= XHCI_BROKEN_MSI;
> xhci_dbg(xhci, "QUIRK: Fresco Logic revision %u "
> "has broken MSI implementation\n",
> pdev->revision);
> xhci->quirks |= XHCI_TRUST_TX_LENGTH;
> }
What prompted you to add these quirks for your system? You're giving me
a solution without explaining what the symptoms are...
> Things seem to work well so far on 3.5.0-rc4 on Gentoo. I get througput as
> expected and no kernel errors.
So what kernel errors were you getting before?
> Not sure if that's the way to do things in the Kernel world, but hopefully
> this can help others with this chipset. :)
Well, you found the bug, and you edited the driver to work around it, so
you should be the one submitting the patch. Just read the documentation
file, it's not too hard. :)
> Thanks to all you Kernel folk who make things happen. :)
You're welcome!
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
