On Fri, Jun 22, 2012 at 02:39:19AM +0000, Pan, Jacob jun wrote: > > > > -----Original Message----- > > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > > Sent: Thursday, June 21, 2012 3:51 PM > > To: Pan, Jacob jun > > Cc: Alan Stern; Du, Alek; Brown, Len; USB list; Wu, Hao > > Subject: Re: Intel Moorestown EHCI and the HOSTPCx registers > > > > On Thu, Jun 21, 2012 at 09:21:44PM +0000, Pan, Jacob jun wrote: > > > > > > > > > > -----Original Message----- > > > > From: Alan Stern [mailto:stern@xxxxxxxxxxxxxxxxxxx] > > > > Sent: Thursday, June 21, 2012 10:25 AM > > > > To: Du, Alek; Pan, Jacob jun; Brown, Len > > > > Cc: USB list > > > > Subject: Intel Moorestown EHCI and the HOSTPCx registers > > > > > > > > Alek and Jacob added support for the Intel Moorestown EHCI > > > > controller, with its special HOSTPCx registers, way back in 2009 > > > > (commit 331ac6b288d9f3689514ced1878041fb0df7e13c). That support > > > > included a new flag, ehci->has_hostpc, which gets tested in lots of places. > > > > > > > > But it never gets set anywhere! All that material is dead code. > > > > > > > > Was it ever tested? Should it be removed? Or should something be > > added? > > > > > > > > What's the story here? > > > > > > > CC Hao, I am no longer working on this. The registers are valid. > > > > Really? I thought Moorestown support was removed from the kernel a while > > ago, shouldn't this also be cleaned up and removed? > The same USB IP block is used in Medfield (the successor of Moorestown). > But I am not sure about the latest effort of upstreaming. As no in-kernel users are using the code, I recommend deleting it, any objection to that? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
