Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Munegowda, Keshava" <keshava_mgowda@xxxxxx> writes:

> On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda
> <keshava_mgowda@xxxxxx> wrote:
>> This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
>> "Fix OMAP EHCI suspend/resume failure (i693)" is causing
>> the usb hub and device detection fails in beagle XM
>> causeing NFS not functional. This affects the core retention too.
>> The same commit logic needs to be revisted adhering to hwmod and
>> device tree framework.
>> for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
>> titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.
>>
>> This patch is validated on BeagleXM with NFS support over
>> usb ethernet and USB mass storage and other device detection.
>>
>> Signed-off-by: Keshava Munegowda <keshava_mgowda@xxxxxx>

[...]

>
> hi kevin
>
> here is pm count log on beagle XM with the above patch:

What are you meaning to show by this log?    

This dump shows that neither PER or CORE are hitting retention in idle.
Which sounds to me like you have not enabled UART runtime suspend:

echo 3000 > /sys/devices/platform/omap_uart.0/power/autosuspend_delay_ms
echo 3000 > /sys/devices/platform/omap_uart.1/power/autosuspend_delay_ms
echo 3000 > /sys/devices/platform/omap_uart.2/power/autosuspend_delay_ms
echo 3000 > /sys/devices/platform/omap_uart.3/power/autosuspend_delay_ms

My test with your patch shows that it fixes the oops during boot, and
doesn't hang during suspend, but that USB host is still preventing CORE
retention during idle (after UART runtime suspend is enabled.)

This happens on 3530/Overo, 3630/Beagle-xM and 3730/Overo

Setting CONFIG_MFD_OMAP_USB_HOST=n allows CORE to hit retention again.

Kevin


>  cat ./debug/pm_debug/count
> usbhost_pwrdm (ON),OFF:0,RET:3,INA:0,ON:4,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0
> sgx_pwrdm (OFF),OFF:1,RET:0,INA:0,ON:1,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0
> core_pwrdm (ON),OFF:0,RET:0,INA:0,ON:1,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0,RET-MEMBANK2-OFF:0
> per_pwrdm (ON),OFF:0,RET:0,INA:0,ON:1,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0
> dss_pwrdm (ON),OFF:0,RET:1254,INA:0,ON:1255,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0
> cam_pwrdm (RET),OFF:0,RET:1,INA:0,ON:1,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0
> neon_pwrdm (ON),OFF:0,RET:1254,INA:0,ON:1255,RET-LOGIC-OFF:0
> mpu_pwrdm (ON),OFF:0,RET:1254,INA:0,ON:1255,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0
> iva2_pwrdm (RET),OFF:0,RET:1,INA:0,ON:1,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0,RET-MEMBANK2-OFF:0,RET-MEMBANK3-OFF:0,RET-MEMBANK4-OFF:0
> usbhost_clkdm->usbhost_pwrdm (3)
> sgx_clkdm->sgx_pwrdm (0)
> per_clkdm->per_pwrdm (19)
> cam_clkdm->cam_pwrdm (0)
> dss_clkdm->dss_pwrdm (1)
> core_l4_clkdm->core_pwrdm (25)
> core_l3_clkdm->core_pwrdm (4)
> d2d_clkdm->core_pwrdm (0)
> iva2_clkdm->iva2_pwrdm (0)
> neon_clkdm->neon_pwrdm (0)
> mpu_clkdm->mpu_pwrdm (0)
> prm_clkdm->wkup_pwrdm (0)
> cm_clkdm->core_pwrdm (0)
>
>
> regards
> keshava
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux