On Wed, Jun 13, 2012 at 12:54:45PM +0200, Daniel Mack wrote: > The hidg function driver currently handles its SET_REPORT calls via EP0. > This is the implicit behaviour when no OUT interrupt endpoint is > configured and generally works fine. > > The problem is that due to EP0's role in the gadget framework, we cannot > hold back packets and control traffic flow to sync it to the char device, > and hence there's a high risk of loosing packets with this > implementation. > > This patch adds an OUT interrupt endpoint to the interface and queues a > fix number of request to catch SET_REPORT events. According to the > specs, host drivers should always use the dedicated OUT endpoint when > present. > > The char device's read implementation was rewritten to retrieve data > from the list of completed output requests. That's a lot of different things all being done at once, can you please break this up into the different logical changes you made here and send this as a series of patches so we can better review them? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
