On Wed, Jun 13, 2012 at 01:09:21PM -0300, Fabio Estevam wrote:
> With the new common clock infrastructure, the following clocks should be
> used on i.MX drivers: ipg, per and ahb.
>
> Adapt fsl_mxc_udc to follow this new behaviour to fix the following probe error:
>
> Freescale High-Speed USB SOC Device Controller driver (Apr 20, 2007)
> fsl-usb2-udc fsl-usb2-udc: clk_get("usb") failed
> fsl-usb2-udc: probe of fsl-usb2-udc failed with error -2
>
>
> @@ -103,21 +96,15 @@ void fsl_udc_clk_finalize(struct platform_device *pdev)
> }
>
> /* ULPI transceivers don't need usbpll */
> - if (pdata->phy_mode == FSL_USB2_PHY_ULPI) {
> - clk_disable(mxc_usb_clk);
> - clk_put(mxc_usb_clk);
> - mxc_usb_clk = NULL;
> - }
> + if (pdata->phy_mode == FSL_USB2_PHY_ULPI)
> + clk_disable_unprepare(mxc_per_clk);
> +
When is finalize called? In FSL_USB2_PHY_ULPI mode this
clk_disable_unprepare seems to be unbalanced with the
clk_disable_unprepare calls below in release()
Sascha
> }
>
> void fsl_udc_clk_release(void)
> {
> - if (mxc_usb_clk) {
> - clk_disable(mxc_usb_clk);
> - clk_put(mxc_usb_clk);
> - }
> - if (!cpu_is_mx35()) {
> - clk_disable(mxc_ahb_clk);
> - clk_put(mxc_ahb_clk);
> - }
> + clk_disable_unprepare(mxc_per_clk);
> + clk_disable_unprepare(mxc_ahb_clk);
> + clk_disable_unprepare(mxc_ipg_clk);
> +
> }
> --
> 1.7.1
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
