On Wed, Jun 13, 2012 at 09:35:23AM -0400, Bart Westgeest wrote: > > On 06/12/2012 05:59 PM, Greg KH wrote: > > >> + retval = (VHCI_NPORTS + 8) / 8; > > What is this for? Isn't there a "round up" function somewhere already? > > I'll fix this. Looks like I should use DIV_ROUND_UP. > > > > >You didn't fix this like I asked you to :( > > > > Greg - forgive my ignorance (or incompetence) here, but what did you > ask me to fix? > > You asked me to resubmit because you were confused on earlier > submissions. However, I am not sure what you have asked me to fix in > the code. > > Are you asking me to resubmit in the original form - 3 parts? > > I guess I am the one that is confused now ... Didn't I ask not to use ? and : in a return statement? That's what I was referring to. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
