Re: [PATCH] gadget: fsl_mxc_udc: do not depend on grouped clocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 13-06-2012 5:14, Fabio Estevam wrote:

From: Fabio Estevam<fabio.estevam@xxxxxxxxxxxxx>

With the new common clock infrastructure, the following clocks should be
used on i.MX drivers: ipg, per and ahb.

Adapt fsl_mxc_udc to follow this new behaviour to fix the following probe error:

Freescale High-Speed USB SOC Device Controller driver (Apr 20, 2007)
fsl-usb2-udc fsl-usb2-udc: clk_get("usb") failed
fsl-usb2-udc: probe of fsl-usb2-udc failed with error -2

Reported-by: Christoph Fritz <chf.fritz@xxxxxxxxxxxxxx>
Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
---
  drivers/usb/gadget/fsl_mxc_udc.c |   22 ++++++++++++++--------
  1 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/gadget/fsl_mxc_udc.c b/drivers/usb/gadget/fsl_mxc_udc.c
index dcbc0a2..20df798 100644
--- a/drivers/usb/gadget/fsl_mxc_udc.c
+++ b/drivers/usb/gadget/fsl_mxc_udc.c
@@ -22,6 +22,7 @@

  static struct clk *mxc_ahb_clk;
  static struct clk *mxc_usb_clk;
+static struct clk *mxc_ipg_clk;

  /* workaround ENGcm09152 for i.MX35 */
  #define USBPHYCTRL_OTGBASE_OFFSET	0x608
@@ -35,12 +36,19 @@ int fsl_udc_clk_init(struct platform_device *pdev)

  	pdata = pdev->dev.platform_data;

+	mxc_ipg_clk = devm_clk_get(&pdev->dev, "ipg");
+	if (IS_ERR(mxc_usb_clk)) {

   Not 'mxc_ipg_clk'?

+		dev_err(&pdev->dev, "clk_get(\"ipg\") failed\n");
+		ret = PTR_ERR(mxc_usb_clk);

   Same question, it looks like copy-paste error...

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux