On Thu, Jun 07, 2012 at 10:20:31AM +0200, stefani@xxxxxxxxxxx wrote: > From: Stefani Seibold <stefani@xxxxxxxxxxx> > > Signed-off-by: Stefani Seibold <stefani@xxxxxxxxxxx> > --- > drivers/usb/usb-skeleton.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c > index 0616f23..efda3a5 100644 > --- a/drivers/usb/usb-skeleton.c > +++ b/drivers/usb/usb-skeleton.c > @@ -114,10 +114,11 @@ static int skel_open(struct inode *inode, struct file *file) > > retval = usb_autopm_get_interface(interface); > if (retval) > - goto out_err; > + goto exit2; > > /* save our object in the file's private structure */ > file->private_data = dev; > +exit2: > mutex_unlock(&dev->io_mutex); That's not so much as a "wrong label" as, "fix unlock bug on error path", right? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html