On Mon, 11 Jun 2012, Namjae Jeon wrote: > Update information of Seagate Portable HDD and WD My Passport HDD in > quirk list. > > Signed-off-by: Namjae Jeon <namjae.jeon@xxxxxxxxxxx> > Signed-off-by: Pankaj Kumar <pankaj.km@xxxxxxxxxxx> > Signed-off-by: Amit Sahrawat <a.sahrawat@xxxxxxxxxxx> > --- > drivers/usb/storage/unusual_devs.h | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h > index 1719886..64f0369 100644 > --- a/drivers/usb/storage/unusual_devs.h > +++ b/drivers/usb/storage/unusual_devs.h > @@ -1267,6 +1267,18 @@ UNUSUAL_DEV( 0x0af0, 0xd357, 0x0000, 0x0000, > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > 0 ), > > +/* Reported by Namjae Jeon <namjae.jeon@xxxxxxxxxxx> > + * Even though write cache is enabled by default, > + * SCSI driver assume that cache is not enabled > + * which in turn might lead to the loss of data > + * since data still will be in cache. > + * So this entry is needed for assuming that cache is enabled. > + */ Please remove everything except the "Reported by" line. The rest is obvious when we see the US_FL_WRITE_CACHE flag. > +UNUSUAL_DEV(0x0bc2, 0x2300, 0x0000, 0x9999, > + "Seagate", > + "Portable HDD", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE), > + > /* Reported by Ben Efros <ben@xxxxxxxxxxxxx> */ > UNUSUAL_DEV( 0x0bc2, 0x3010, 0x0000, 0x0000, > "Seagate", > @@ -1468,6 +1480,18 @@ UNUSUAL_DEV( 0x1058, 0x0704, 0x0000, 0x9999, > USB_SC_DEVICE, USB_PR_DEVICE, NULL, > US_FL_SANE_SENSE), > > +/* Reported by Namjae Jeon <namjae.jeon@xxxxxxxxxxx> > + * Even though write cache is enabled by default, > + * SCSI driver assume that cache is not enabled > + * which in turn might lead to the loss of data > + * since data still will be in cache. > + * So this entry is needed for assuming that cache is enabled. > + */ Same here. > +UNUSUAL_DEV(0x1058, 0x070a, 0x0000, 0x9999, > + "Western Digital", > + "My Passport HDD", > + USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE), Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
