On Mon, 11 Jun 2012, Shimoda, Yoshihiro wrote: > If the platform_data is not set, pdata will be uninitialized value. > Then, the phy_init() may run on illegal address. I don't see how this patch fixes that problem. > This patch also fixes the following warning: > > CC drivers/usb/host/ehci-hcd.o > drivers/usb/host/ehci-sh.c: In function ‘ehci_hcd_sh_probe’: > drivers/usb/host/ehci-sh.c:104: warning: ‘pdata’ may be used uninitialized in this function That alone is a good enough reason to accept the patch. You might want to update the patch description, though. > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > --- > drivers/usb/host/ehci-sh.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ehci-sh.c b/drivers/usb/host/ehci-sh.c > index ca819cd..e7cb392 100644 > --- a/drivers/usb/host/ehci-sh.c > +++ b/drivers/usb/host/ehci-sh.c > @@ -126,8 +126,7 @@ static int ehci_hcd_sh_probe(struct platform_device *pdev) > goto fail_create_hcd; > } > > - if (pdev->dev.platform_data != NULL) > - pdata = pdev->dev.platform_data; > + pdata = pdev->dev.platform_data; > > /* initialize hcd */ > hcd = usb_create_hcd(&ehci_sh_hc_driver, &pdev->dev, Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
