Re: [uclinux-dist-devel] [PATCH v2] drivers: usb: musb: add bf60x support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 5, 2012 at 7:30 AM, Felipe Balbi <balbi@xxxxxx> wrote:
> On Wed, May 30, 2012 at 02:11:17PM +0800, Bob Liu wrote:
>> --- a/drivers/usb/musb/blackfin.h
>> +++ b/drivers/usb/musb/blackfin.h
>> @@ -84,4 +84,10 @@ static void dump_fifo_data(u8 *buf, u16 len)
>>
>>  static struct timer_list musb_conn_timer;
>>
>> +#ifndef CONFIG_BF60x
>> +#define vrsel_set_value(val) gpio_set_value(musb->config->gpio_vrsel, val)
>> +#else
>> +#define vrsel_set_value(val) do { } while (0)
>> +#endif
>
> this obfuscation is unnacceptable and it won't even work if you want to
> have support for both blackfins on the same kernel.

there are no plans to do that, and a lot more fundamental stuff would
have to be sorted out before that could even be considered
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux