Am Donnerstag, 7. Juni 2012, 10:20:33 schrieb stefani@xxxxxxxxxxx:
> From: Stefani Seibold <stefani@xxxxxxxxxxx>
>
> All code which use processed_urb can be eliminated.
If you eliminate it, how do you balance the completion?
Regards
Oliver
>
> Signed-off-by: Stefani Seibold <stefani@xxxxxxxxxxx>
> ---
> drivers/usb/usb-skeleton.c | 12 ------------
> 1 files changed, 0 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
> index 7385aa8..92cdfca 100644
> --- a/drivers/usb/usb-skeleton.c
> +++ b/drivers/usb/usb-skeleton.c
> @@ -59,7 +59,6 @@ struct usb_skel {
> __u8 bulk_out_endpointAddr; /* the address of the bulk out endpoint */
> int errors; /* the last request tanked */
> bool ongoing_read; /* a read is going on */
> - bool processed_urb; /* indicates we haven't processed the urb */
> spinlock_t err_lock; /* lock for errors */
> struct kref kref;
> struct mutex io_mutex; /* synchronize I/O with disconnect */
> @@ -256,17 +255,6 @@ retry:
> * we must finish now
> */
> dev->bulk_in_copied = 0;
> - dev->processed_urb = true;
> - }
> -
> - if (!dev->processed_urb) {
> - /*
> - * the URB hasn't been processed
> - * do it now
> - */
> - wait_for_completion(&dev->bulk_in_completion);
> - dev->bulk_in_copied = 0;
> - dev->processed_urb = true;
> }
>
> /* errors must be reported */
> --
> 1.7.8.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
