Hi,
On Wed, Jun 06, 2012 at 07:18:29PM +0530, Pratyush Anand wrote:
> Signed-off-by: Pratyush Anand <pratyush.anand@xxxxxx>
have added a commit log to this patch and kept n between parens:
commit 7e39b817ee64a8b67282c76f52aaabddc8a5cd26
Author: Pratyush Anand <pratyush.anand@xxxxxx>
Date: Wed Jun 6 19:18:29 2012 +0530
usb: dwc3: Correct DWC3_DCTL_HIRD_THRES definition
The definition of DWC3_DCTL_HIRD_THRES macro is
completely wrong. It will only work for when we
want to read the register's contents for that bitfield.
Change the macro so that it can be used to writing to
the register, and when we need to read, we can add
extra right shift of 24 bits.
Signed-off-by: Pratyush Anand <pratyush.anand@xxxxxx>
[ balbi@xxxxxx: add a commit log ]
Signed-off-by: Felipe Balbi <balbi@xxxxxx>
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index fcb8be2..d3e56cf 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -223,7 +223,7 @@
#define DWC3_DCTL_LSFTRST (1 << 29)
#define DWC3_DCTL_HIRD_THRES_MASK (0x1f << 24)
-#define DWC3_DCTL_HIRD_THRES(n) (((n) & DWC3_DCTL_HIRD_THRES_MASK) >> 24)
+#define DWC3_DCTL_HIRD_THRES(n) ((n) << 24)
#define DWC3_DCTL_APPL1RES (1 << 23)
ps: still waiting patch 2, probably lost on mail servers
--
balbi
Attachment:
signature.asc
Description: Digital signature
