Hi, On Wed, Jun 06, 2012 at 03:57:55PM +0530, Pratyush Anand wrote: > On Thu, May 24, 2012 at 4:04 PM, Felipe Balbi <balbi@xxxxxx> wrote: > > From: Paul Zimmerman <Paul.Zimmerman@xxxxxxxxxxxx> > > > > Recent cores (>= 1.94a) have a set of new features, > > commands and a slightly different programming model. > > > > This patch aims to support those changes. > > > > Signed-off-by: Paul Zimmerman <paulz@xxxxxxxxxxxx> > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > --- > > drivers/usb/dwc3/gadget.c | 83 ++++++++++++++++++++++++++++++++++++++------- > > 1 file changed, 70 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > > index 852bde5..0404833 100644 > > --- a/drivers/usb/dwc3/gadget.c > > +++ b/drivers/usb/dwc3/gadget.c > > ... > > > + /* TODO: This should be configurable */ > > + reg |= DWC3_DCTL_HIRD_THRES(31); > > + > > + dwc3_writel(dwc->regs, DWC3_DCTL, reg); > > + > > + dwc3_gadget_usb2_phy_suspend(dwc, true); > > + dwc3_gadget_usb3_phy_suspend(dwc, true); > > I think, these should be false > > Also DWC3_DCTL_HIRD_THRES definition is not correct. Indeed. That was actually my fault when I split Paul's patches. Can you send a patch fixing those on top of what's already there ? I can't rebase my branches anymore. ps: this should be done in two patches: one for HIRD definition, and one fixing phy_suspend's argument. -- balbi
Attachment:
signature.asc
Description: Digital signature
