Re: [PATCH 1/4] usb: dwc3: gadget: drop useless code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/6/2012 1:10 PM, Felipe Balbi wrote:
On Wed, Jun 06, 2012 at 01:11:42PM +0530, Pratyush Anand wrote:
On 6/6/2012 1:05 PM, Felipe Balbi wrote:
On Wed, Jun 06, 2012 at 01:04:00PM +0530, Pratyush Anand wrote:
On 6/6/2012 12:37 PM, Felipe Balbi wrote:
Hi Pratyush,

On Wed, Jun 06, 2012 at 10:04:34AM +0300, Felipe Balbi wrote:
We never set CMDIOC bit for Start Transfer
command, so that code will never be used.

Signed-off-by: Felipe Balbi<balbi@xxxxxx>

Just FYI, I tested this series with g_mass_storage and g_zero by
removing a cable with a transfer going on and later reconnecting. I
didn't see any crashes while doing that.

I still got one warning, but that's because I'm running 1.83a which has
a bug of missing disconnect IRQs which is triggering, so nevermind that
WARN.

Let me know how testing goes on your side.


Its almost working :)

Only one warning now I see from  dwc3_endpoint_interrupt

Transfer In-Progress while ep2in not enabled.

That's the one I added on purpose so we could track this case. Do you
think I should just drop it ?


I think, its safe to return here. So 4th patch can be amended.

sure, I will do just that. May I add your Tested-by to all 4 patches ?


Sure, You can add it.


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux