On Tue, 5 Jun 2012, Marek Vasut wrote:
> > > > + /* FIXME:
> > > > + * - it does not work for multi-phy ehci
> > > > + * - the best place is after debounce, but I can't get
> > > > + * phy there
> > > > + */
> > > > + if ((pstatus & PORT_CSC) && ehci->transceiver) {
> >
> > Do the tests in the opposite order and add "unlikely":
> >
> > if (unlikely(ehci->transceiver &&
> > (pstatus & PORT_CSC)) {
> >
> > That way it will fail more quickly on systems where it doesn't apply or
> > for unaffected ports.
>
> Does this unlikely() have any effect on ARM/MIPS/PPC, where this chipidea IP is
> used ? Or is there some x86 device sporting this IP too?
I don't know what unlikely() does on architectures other than x86. And
I haven't heard of any x86 systems that would need to use this code.
On the other hand, port-status changes don't occur very frequently. A
little time penalty one way or the other won't make much difference.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
