Re: [PATCH 06/10] usb: gadget: mv_udc_core: Remove unneeded condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2012/6/4 Ido Shayevitz <idos@xxxxxxxxxxxxxx>:
> The removed condition is always true, since the endpoint descriptor is
> set prior to calling the enable endpoint.
>
> Signed-off-by: Ido Shayevitz <idos@xxxxxxxxxxxxxx>

Acked-by: Yu Xu <yuxu@xxxxxxxxxxx>

> ---
>  drivers/usb/gadget/mv_udc_core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c
> index dbcd132..117a4bb 100644
> --- a/drivers/usb/gadget/mv_udc_core.c
> +++ b/drivers/usb/gadget/mv_udc_core.c
> @@ -464,7 +464,7 @@ static int mv_ep_enable(struct usb_ep *_ep,
>        ep = container_of(_ep, struct mv_ep, ep);
>        udc = ep->udc;
>
> -       if (!_ep || !desc || ep->ep.desc
> +       if (!_ep || !desc
>                        || desc->bDescriptorType != USB_DT_ENDPOINT)
>                return -EINVAL;
>
> --
> 1.7.6
>
> Consultant for Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux