Hi, On Fri, Jun 01, 2012 at 04:01:24AM -0700, Tony Lindgren wrote: > * Felipe Balbi <balbi@xxxxxx> [120529 05:22]: > > that print isn't needed at all. Remove it > > and move the use_dma reinitialization to > > probe() function. > > > > Note that ideally we would drop all > > cpu_is_* and machine_is_* checks from > > this driver instead. Later patches will > > come to get rid of those. > > > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > --- > > drivers/usb/gadget/omap_udc.c | 13 +++---------- > > 1 file changed, 3 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c > > index aa2d174..5e7b891 100644 > > --- a/drivers/usb/gadget/omap_udc.c > > +++ b/drivers/usb/gadget/omap_udc.c > > @@ -2800,6 +2800,9 @@ static int __init omap_udc_probe(struct platform_device *pdev) > > struct clk *dc_clk = NULL; > > struct clk *hhc_clk = NULL; > > > > + if (cpu_is_omap7xx()) > > + use_dma = 0; > > + > > /* NOTE: "knows" the order of the resources! */ > > if (!request_mem_region(pdev->resource[0].start, > > pdev->resource[0].end - pdev->resource[0].start + 1, > > I think this would break omap_udc for 7xx as it then tries to use > DMA as USED_MA is set by default? I'm clearing it in the start of probe function. There's not functional changes at all. use_dma is ON by default, then our probe gets called and first thing we do is clear use_dma to zero when we're running on omap7xx. I don't see the issue, maybe I'm missing something. -- balbi
Attachment:
signature.asc
Description: Digital signature
