On Mon, May 21, 2012 at 05:36:16PM +0800, Richard Zhao wrote:
> On Mon, May 21, 2012 at 12:26:36PM +0300, Felipe Balbi wrote:
> > On Mon, May 21, 2012 at 05:23:46PM +0800, Richard Zhao wrote:
> > > This let usb phy driver has a chance to change hw settings when connect
> > > status change.
> > >
> > > Signed-off-by: Richard Zhao <richard.zhao@xxxxxxxxxxxxx>
> > > ---
> > > include/linux/usb/otg.h | 13 +++++++++++++
> > > 1 files changed, 13 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h
> > > index 38ab3f4..385641d 100644
> > > --- a/include/linux/usb/otg.h
> > > +++ b/include/linux/usb/otg.h
> > > @@ -117,6 +117,10 @@ struct usb_phy {
> > > int (*set_suspend)(struct usb_phy *x,
> > > int suspend);
> > >
> > > + /* notify phy connect status change */
> > > + int (*notify_connect_change)(struct usb_phy *x,
> > > + int port,
> > > + int connected);
> > > };
> > >
> > >
> > > @@ -252,6 +256,15 @@ usb_phy_set_suspend(struct usb_phy *x, int suspend)
> > > }
> > >
> > > static inline int
> > > +usb_phy_notify_connect_change(struct usb_phy *x, int port, int connected)
> > > +{
> > > + if (x->notify_connect_change != NULL)
> >
> > you don't need this != NULL. See that no other wrapper has it. Keep
> > consistency.
> notify_connect_change callback is not a must. I just let the phy driver
> have a chance to do whatever it needs to do.
what I meant was:
- if (x->notify_connect_change != NULL)
+ if (x->notify_connect_change)
> > Also, this is the kind of stuff that I have been queueing for Greg so I
> > should be in Cc.
> Ah, I'm really sorry. I just find out I used the result of get_maintainer
> for v1 patchset.
hmm... ok, looks like I should patch MAINTAINERS file for that :-p
Greg, is it ok ?
--
balbi
Attachment:
signature.asc
Description: Digital signature
