On Mon, May 21, 2012 at 02:37:13PM +0530, Pratyush Anand wrote: > On 5/21/2012 2:23 PM, Felipe Balbi wrote: > >On Mon, May 21, 2012 at 12:45:46PM +0530, Pratyush Anand wrote: > >>SOF Number is bit16:3 of DSTS. Corrct the mask accordingly. > >> > >>Signed-off-by: Pratyush Anand<pratyush.anand@xxxxxx> > >>--- > >> drivers/usb/dwc3/core.h | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >>diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > >>index 0b620b7..8079066 100644 > >>--- a/drivers/usb/dwc3/core.h > >>+++ b/drivers/usb/dwc3/core.h > >>@@ -254,7 +254,7 @@ > >> > >> #define DWC3_DSTS_RXFIFOEMPTY (1<< 17) > >> > >>-#define DWC3_DSTS_SOFFN_MASK (0x3ff<< 3) > >>+#define DWC3_DSTS_SOFFN_MASK (0x1fff<< 3) > > > >That should be 0x3fff, no ? I just missed on "0xf" from the mask. > > > Ohh yes.. Its till bit 16. So , sorry. no problem. We only missed this because no gadget driver is using usb_gadget_get_frame() :-) Maybe the Isochronous-based drivers should start using it when queueing requests, dunno... that's a longer discussion :-) Thanks for spotting this out. -- balbi
Attachment:
signature.asc
Description: Digital signature
