Re: [PATCH] USB: ehci-platform: remove update_device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/18/2012 08:38 PM, Greg KH wrote:
> On Fri, May 18, 2012 at 08:29:56PM +0200, Hauke Mehrtens wrote:
>> The update_device callback is not needed and the function used here is
>> from the pci ehci driver. Without this patch we get a compile error if
>> ehci-platform is compiled without ehci-pci.
>>
>> Signed-off-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
>> ---
>>
>> This should also go into 3.4 as it fixes a compile problem.
> 
> What systems and/or configurations cause this build problem?
> 
> thanks,
> 
> greg k-h

If CONFIG_PCI is unset and CONFIG_USB_EHCI_HCD_PLATFORM is set we get an
compile error, because ehci_update_device() is missing.
ehci_update_device() is a static function in ehci-pci.c. This
configuration is possible on the Mips based Atheros AR71XX platform and
I got a user report about this.

ehci-vt8500.c also looks suspicious to this problem as it does the same
thing, but I do not know if it is possible to build this without pci
support.

Hauke
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux