Hi, On Fri, May 18, 2012 at 2:19 PM, Chen Peter-B29397 <B29397@xxxxxxxxxxxxx> wrote: > > > >> > The above commit causes failure of imx usb host hub detection. >> >> This commit may introduce an overriding problem on initial configuration >> of CMD: initial configuration of CMD is figured out in ehci_init, but is >> override later in the following ehci_reset, see ehci_setup. >> >> So could you please try the below patch to see if it can fix your problem? >> > > Hi ming, > > I have applied your patch at the top of usb-next > (0b623f871d7c993fac8ad7aaaa8f5f3cdb8ed480) > But there is still error after hub enumeration finishes (ep0 is finished). > below is the error message: > > usb 1-1: new high-speed USB device number 2 using mxc-ehci > hub 1-1:1.0: USB hub found > hub 1-1:1.0: 7 ports detected > mxc-ehci mxc-ehci.1: fatal error > mxc-ehci mxc-ehci.1: HC died; cleaning up > mxc-ehci mxc-ehci.1: force halt; handshake f5780344 00004000 00004000 -> -110 > mxc-ehci mxc-ehci.1: HC died; cleaning up > hub 1-1:1.0: hub_port_status failed (err = -108) > usb 1-1: USB disconnect, device number 2 > > I will have a look this afternoon, hope there is a update this afternoon. Looks the patch has no effect on mxc ehci because mxc has its own setup helper of ehci_mxc_setup, so could you please try the below against last patch to see any improvement? diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c index c778ffe..2f7e702 100644 --- a/drivers/usb/host/ehci-mxc.c +++ b/drivers/usb/host/ehci-mxc.c @@ -61,7 +61,7 @@ static int ehci_mxc_setup(struct usb_hcd *hcd) ehci->sbrn = 0x20; - ehci_reset(ehci); + ehci_hw_init(ehci); ehci_port_power(ehci, 0); return 0; Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
