> > > > Could the ehci-hcd driver include a hook to call the appropriate > PHY > > > > driver at the right times? > > > > > > But that sounds like quite unsystematic hack. I'd like to avoid > poluting > > > the code only because one stupid controller needs it. > > > > It's reasonable to assume that other controllers in the future may have > > similar needs -- they may even require multiple PHYs to be notified > > about connect changes on multiple ports. I see nothing wrong with > > implementing a callback just for this purpose. Something like: > > > > void (*phy_connect_change)(unsigned port, int connected); > > > > Then in the port loop in ehci_irq(), you could do: > > > > if (unlikely(ehci->phy_connect_change && (pstatus & PORT_CSC))) > > (ehci->phy_connect_change)(i, pstatus & PORT_CONNECT); Hi Alan & Marek, It is just FSL PHY's limitation, we can override ehci_irq at platform driver to finish the same thing. Better not to change common code, the cleaner the better for common code. > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
