Hello Greg, On Tuesday, May 15, 2012 4:14 PM Greg Kroah-Hartman wrote: <snip> > > > > +source "drivers/staging/ccg/Kconfig" > > > > + > > > > > > Why are you including this here and not in drivers/staging/Kconfig? > > > That is where it should be to show that this really is a staging driver. > > > > > > > Ok, I know it is a hack. I should have said something about > > it when I posted it. The hack is applied because of the way the usb gadget > > driver is built, specially for the compiled-in case: during the kernel > > configuration only one variant of the gadget (e.g. Gadget Zero, Mass > > Storage, > > Printer, Ethernet and so on), can be exclusively selected. > > So I wanted the ccg (Configurable Composite Gadget) to be one of these > > mutually-exclusive options while at the same place it in staging. > > What do you think? > > I think I want all staging drivers to be self-contained as much as > possible in the drivers/staging/ directory. So please do not put this > Kconfig include line into drivers/usb/gadget/Kconfig, but rather, in > drivers/staging/. Please move it there and I will be glad to accept it. > The patch formulated according to your opinion has been submitted. Changing it was easier than I thought. Kconfig rules! ;) Thanks, Andrzej -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
