> > > >>> USB transceiver (PHY) may be different for kinds of SoC vendors. > >>> Some uses chipidea internal UTMI PHY, in this case, only PHCD is > >>> needed to controller PHY's suspend/resume. Some does not use > >>> chipidea PHY (ULPI or vendor's UTMI PHY), in this case, PHY's > operation > >>> is not only set/clear phcd, it may includes some others, like close > >>> PHY's analog part, PHY's clock, etc. > >>> > >>> So, I prefer to put PHY's operation at PHY's driver, it is platform > >>> related. > >>> > >> Ok, but isn't it a separate issue ? > >> This patch clean the current code. We can add later phy layer > >> integration ? > >> > > but it changes the behavior when has_hostpc=0 or has_lpm = 0, > > at current code, it will not set phcd after bus suspend, but your patch > will. > ATM has_tdi_phy_lpm is set only when has_hostpc=1, so the patch won't do > anything when has_hostpc=0 or has_lpm = 0. Understand your patchset now, thanks. > > > Matthieu -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html