Re: [RFC/PATCH 4/4] add phy low power suspend for older chipidea core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 05/14/2012 07:17 PM, Matthieu CASTET wrote:

Signed-off-by: Matthieu CASTET<matthieu.castet@xxxxxxxxxx>
---
  drivers/usb/host/ehci-hub.c |   46 +++++++++++++++++++++++++++----------------
  1 file changed, 29 insertions(+), 17 deletions(-)

diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
index b70fca6..3b3f201 100644
--- a/drivers/usb/host/ehci-hub.c
+++ b/drivers/usb/host/ehci-hub.c
@@ -33,34 +33,46 @@

 static void tdi_phy_lpm_clear(struct ehci_hcd *ehci, int port)
 {
+	u32 temp;
+	u32 __iomem *reg;
+	u32 bit;

An empty line after declaration block wouldn't hurt -- you have it in the next function...

 	if (ehci->has_hostpc) {
[...]
 }

  static void tdi_phy_lpm_set(struct ehci_hcd *ehci, int port)
  {
-	if (ehci->has_hostpc) {
-		u32 __iomem	*hostpc_reg;
-		u32		t3;
+	u32 __iomem *reg;
+	u32		t3;

   Why indent 't3' -- quite unexpectedly?

+	u32 bit;

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux