Re: [PATCH] usb:hsotg:samsung:cosmetic Move <linux/platform_data/s3c-hsotg.h> to proper place

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 09, 2012 at 01:16:53PM +0200, Lukasz Majewski wrote:
> This commit adds a cosmetic change to the s3c-hsotg UDC driver.
> It moves s3c-hsotg.h to other linux/ related inclusions.
> 
> Signed-off-by: Lukasz Majewski <l.majewski@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
>  arch/arm/mach-exynos/mach-nuri.c           |    2 +-
>  arch/arm/mach-exynos/mach-universal_c210.c |    2 +-
>  arch/arm/mach-s3c64xx/mach-crag6410.c      |    2 +-
>  arch/arm/mach-s3c64xx/mach-smartq.c        |    2 +-
>  arch/arm/mach-s3c64xx/mach-smdk6410.c      |    2 +-
>  arch/arm/mach-s5pv210/mach-goni.c          |    2 +-
>  arch/arm/plat-samsung/devs.c               |    2 +-
>  drivers/usb/gadget/s3c-hsotg.c             |    2 +-
>  8 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/mach-nuri.c b/arch/arm/mach-exynos/mach-nuri.c
> index 9c97d7c..2c6d701 100644
> --- a/arch/arm/mach-exynos/mach-nuri.c
> +++ b/arch/arm/mach-exynos/mach-nuri.c
> @@ -25,6 +25,7 @@
>  #include <linux/mmc/host.h>
>  #include <linux/fb.h>
>  #include <linux/pwm_backlight.h>
> +#include <linux/platform_data/s3c-hsotg.h>
>  
>  #include <video/platform_lcd.h>
>  #include <media/m5mols.h>
> @@ -44,7 +45,6 @@
>  #include <plat/fb.h>
>  #include <plat/sdhci.h>
>  #include <plat/ehci.h>
> -#include <linux/platform_data/s3c-hsotg.h>
>  #include <plat/clock.h>
>  #include <plat/gpio-cfg.h>
>  #include <plat/iic.h>
> diff --git a/arch/arm/mach-exynos/mach-universal_c210.c b/arch/arm/mach-exynos/mach-universal_c210.c
> index 62f159a..bc8bf3b 100644
> --- a/arch/arm/mach-exynos/mach-universal_c210.c
> +++ b/arch/arm/mach-exynos/mach-universal_c210.c
> @@ -23,6 +23,7 @@
>  #include <linux/i2c-gpio.h>
>  #include <linux/i2c/mcs.h>
>  #include <linux/i2c/atmel_mxt_ts.h>
> +#include <linux/platform_data/s3c-hsotg.h>
>  
>  #include <asm/mach/arch.h>
>  #include <asm/hardware/gic.h>
> @@ -42,7 +43,6 @@
>  #include <plat/fimc-core.h>
>  #include <plat/camport.h>
>  #include <plat/mipi_csis.h>
> -#include <linux/platform_data/s3c-hsotg.h>
>  
>  #include <mach/map.h>
>  
> diff --git a/arch/arm/mach-s3c64xx/mach-crag6410.c b/arch/arm/mach-s3c64xx/mach-crag6410.c
> index a02f204..b9f4d25 100644
> --- a/arch/arm/mach-s3c64xx/mach-crag6410.c
> +++ b/arch/arm/mach-s3c64xx/mach-crag6410.c
> @@ -31,6 +31,7 @@
>  #include <linux/spi/spi.h>
>  
>  #include <linux/i2c/pca953x.h>
> +#include <linux/platform_data/s3c-hsotg.h>
>  
>  #include <video/platform_lcd.h>
>  
> @@ -61,7 +62,6 @@
>  #include <plat/sdhci.h>
>  #include <plat/gpio-cfg.h>
>  #include <plat/s3c64xx-spi.h>
> -#include <linux/platform_data/s3c-hsotg.h>
>  
>  #include <plat/keypad.h>
>  #include <plat/clock.h>
> diff --git a/arch/arm/mach-s3c64xx/mach-smartq.c b/arch/arm/mach-s3c64xx/mach-smartq.c
> index ee0d13c..ceeb1de 100644
> --- a/arch/arm/mach-s3c64xx/mach-smartq.c
> +++ b/arch/arm/mach-s3c64xx/mach-smartq.c
> @@ -18,6 +18,7 @@
>  #include <linux/serial_core.h>
>  #include <linux/spi/spi_gpio.h>
>  #include <linux/usb/gpio_vbus.h>
> +#include <linux/platform_data/s3c-hsotg.h>
>  
>  #include <asm/mach-types.h>
>  #include <asm/mach/map.h>
> @@ -33,7 +34,6 @@
>  #include <plat/gpio-cfg.h>
>  #include <plat/hwmon.h>
>  #include <plat/regs-serial.h>
> -#include <linux/platform_data/s3c-hsotg.h>
>  #include <plat/usb-control.h>
>  #include <plat/sdhci.h>
>  #include <plat/ts.h>
> diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c b/arch/arm/mach-s3c64xx/mach-smdk6410.c
> index bf477e3..4bc5c74 100644
> --- a/arch/arm/mach-s3c64xx/mach-smdk6410.c
> +++ b/arch/arm/mach-s3c64xx/mach-smdk6410.c
> @@ -30,6 +30,7 @@
>  #include <linux/regulator/fixed.h>
>  #include <linux/regulator/machine.h>
>  #include <linux/pwm_backlight.h>
> +#include <linux/platform_data/s3c-hsotg.h>
>  
>  #ifdef CONFIG_SMDK6410_WM1190_EV1
>  #include <linux/mfd/wm8350/core.h>
> @@ -72,7 +73,6 @@
>  #include <plat/keypad.h>
>  #include <plat/backlight.h>
>  #include <plat/regs-fb-v4.h>
> -#include <linux/platform_data/s3c-hsotg.h>
>  
>  #include "common.h"
>  
> diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c
> index 781fed6..93ab278 100644
> --- a/arch/arm/mach-s5pv210/mach-goni.c
> +++ b/arch/arm/mach-s5pv210/mach-goni.c
> @@ -27,6 +27,7 @@
>  #include <linux/gpio.h>
>  #include <linux/mmc/host.h>
>  #include <linux/interrupt.h>
> +#include <linux/platform_data/s3c-hsotg.h>
>  
>  #include <asm/hardware/vic.h>
>  #include <asm/mach/arch.h>
> @@ -50,7 +51,6 @@
>  #include <plat/mfc.h>
>  #include <plat/regs-fb-v4.h>
>  #include <plat/camport.h>
> -#include <linux/platform_data/s3c-hsotg.h>
>  
>  #include <media/v4l2-mediabus.h>
>  #include <media/s5p_fimc.h>
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index a41c808..b728905 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -30,6 +30,7 @@
>  #include <linux/mmc/host.h>
>  #include <linux/ioport.h>
>  #include <linux/platform_data/s3c-hsudc.h>
> +#include <linux/platform_data/s3c-hsotg.h>
>  
>  #include <asm/irq.h>
>  #include <asm/pmu.h>
> @@ -57,7 +58,6 @@
>  #include <plat/sdhci.h>
>  #include <plat/ts.h>
>  #include <plat/udc.h>
> -#include <linux/platform_data/s3c-hsotg.h>
>  #include <plat/usb-control.h>
>  #include <plat/usb-phy.h>
>  #include <plat/regs-iic.h>
> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index 5061a2f..f4abb0e 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -32,11 +32,11 @@
>  
>  #include <linux/usb/ch9.h>
>  #include <linux/usb/gadget.h>
> +#include <linux/platform_data/s3c-hsotg.h>
>  
>  #include <mach/map.h>
>  
>  #include "s3c-hsotg.h"
> -#include <linux/platform_data/s3c-hsotg.h>
>  
>  #define DMA_ADDR_INVALID (~((dma_addr_t)0))

cool, thanks a lot. I will apply soon, but can you also cook a patch
getting rid of this DMA_ADDR_INVALID and making use of generic map/unmap
routines ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux