On Fri, May 11, 2012 at 04:08:30PM +0800, Lan Tianyu wrote: > +struct usb_device *usb_get_hub_child_device(struct usb_device *hdev, > + int port1) > +{ > + struct usb_hub *hub = hdev_to_hub(hdev); > + > + if (!hub || port1 > hdev->maxchild || port1 < 1) > + return NULL; > + return hub->port_data[port1 - 1].child; > +} > +EXPORT_SYMBOL_GPL(usb_get_hub_child_device); We need kerneldoc documentation for this new public function. Please send a follow-on patch that adds this. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html