Re: [PATCH v9 08/20] usb: chipidea: add support for roles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 11, 2012 at 05:25:47PM +0300, Alexander Shishkin wrote:
> Add some generic code for roles and implement simple role switching
> based on ID pin state and/or a sysfs file. At this, we also rename
> the device to ci_hdrc, which is what it is.
> 
> The "manual" switch is made into a sysfs file and not debugfs, because
> it might be useful even in non-debug context. For some boards, like
> sheevaplug, it seems to be the only way to switch roles without modifying
> the hardware, since the ID pin is always grounded.

That's nice you added a sysfs file, but that means you need to add a
Documentation/ABI file also that describes it.  Please send me a
follow-on patch that does just that as soon as possible.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux