Hi, On Fri, May 11, 2012 at 8:34 AM, Peter Chen <peter.chen@xxxxxxxxxxxxx> wrote: > On Thu, May 10, 2012 at 02:35:30PM +0200, Marek Vasut wrote: >> Dear Sascha Hauer, >> >> > On Thu, May 10, 2012 at 05:27:37PM +0530, Kishon Vijay Abraham I wrote: >> > > Add a linked list for keeping multiple PHY instances with different >> > > types so that we can have separate USB2 and USB3 PHYs on one single >> > > board. _get_phy_ has been changed so that the controller gets >> > > the transceiver by type. _remove_phy_ has been added to let the phy >> > > be removed from the phy list. >> > >> > We need such a thing, but there should be a way to associate a phy with >> > a USB port. Otherwise it won't work when multiple phys of the same type >> > are present in the system. >> >> +1 on this one > Hi Kishon, > > Thanks for working on this, but it is just a PHY list, not the PHY layer > used by PHY driver and controller driver who wants to use PHY. > Besides, no USB Spec says there is relationship between OTG and USB PHY. > Heikki's (including mine) aim is separate PHY from OTG, and create a > generic PHY layer. A generic PHY layer is like below: > > - There is separate folder at drivers/usb/phy, which includes generic PHY > files and platform PHY drivers. > - Platform PHY driver will add itself to PHY list, and implement kinds of > PHY utilities, like init, suspend, wakeup, charger detector, etc. > - The PHY user (controller driver, no only otg driver) will get the PHY, > and use it. Completely agree with you. But before we have the generic PHY layer, we got to have multi-phy support. It's needed for usb3 controller in OMAP5 where it needs usb2 phy and usb3 phy. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html