Re: usb: gadget: ci13xxx: replace home-brewed logging with dev_{err,warn,info}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 10, 2012 at 04:26:20PM +0300, Dan Carpenter wrote:
> Hello Alexander Shishkin,
> 
> This is a semi-automatic email about new static checker warnings.
> 
> The patch 0f089094cde5: "usb: gadget: ci13xxx: replace home-brewed 
> logging with dev_{err,warn,info}" from May 8, 2012, leads to the 
> following Smatch complaint:
> 
> drivers/usb/gadget/ci13xxx_udc.c:2723 udc_irq()
> 	 error: we previously assumed 'udc' could be null (see line 2722)
> 
> drivers/usb/gadget/ci13xxx_udc.c
>   2721	
>   2722		if (udc == NULL) {
>   2723			dev_err(udc->dev, "ENODEV");
>                                 ^^^^^^^^
> Derp.
> 
>   2724			return IRQ_HANDLED;
>   2725		}

Thanks for this report, I've now fixed it in my tree.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux