Hello Alexander Shishkin,
This is a semi-automatic email about new static checker warnings.
The patch 62bb84ed0e4d: "usb: gadget: ci13xxx: convert to platform
device" from May 8, 2012, leads to the following Smatch complaint:
drivers/usb/gadget/ci13xxx_pci.c:54 ci13xxx_pci_probe()
warn: variable dereferenced before check 'id' (see line 49)
drivers/usb/gadget/ci13xxx_pci.c
48 {
49 struct ci13xxx_udc_driver *driver = (void *)id->driver_data;
^^^^^^^^^^^^^^^^
New dereference.
50 struct platform_device *plat_ci;
51 struct resource res[3];
52 int retval = 0, nres = 2;
53
54 if (id == NULL)
^^^^^^^^^^
Old check. My guess is the check isn't needed.
55 return -EINVAL;
56
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
